Re: [boot-wrapper PATCH v2 3/8] aarch64: Remove the redundant setup_stack
From: Andre Przywara <andre.przywara@arm.com>
Date: 2021-05-24 19:08:50
On Fri, 21 May 2021 18:48:02 +0800 Jaxson Han [off-list ref] wrote:
Since we already have set up a stack above, there is no need to do it again.
Indeed, in fact it's a bug: setup_stack expects the logical CPU ID in w0, and here we always call it with w0 being 1.
Signed-off-by: Jaxson Han <redacted>
Reviewed-by: Andre Przywara <andre.przywara@arm.com> Thanks! Andre
quoted hunk ↗ jump to hunk
--- arch/aarch64/boot.S | 1 - 1 file changed, 1 deletion(-)diff --git a/arch/aarch64/boot.S b/arch/aarch64/boot.S index e4f5f3d..ee9886b 100644 --- a/arch/aarch64/boot.S +++ b/arch/aarch64/boot.S@@ -39,7 +39,6 @@ _start: ldr x1, =flag_keep_el str w0, [x1] - bl setup_stack b start_keep_el /*
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel