Re: [PATCH] arm64: Generate cpucaps.h
From: Mark Brown <broonie@kernel.org>
Date: 2021-05-13 12:48:04
On Thu, May 13, 2021 at 10:35:04AM +0530, Anshuman Khandual wrote:
Small nit. So going forward this new directory (arch/arm64/tools/), will be used to hold similar scripts that generate header or similar things ?
Yes, anything we need to run in the build process. Some of the other architectures have some tools to verify generated binaries have particular properties as well for example.
At first the directory name 'tool' was bit confusing but seems like other archs (arm, m68k, mips, powerpc, s390, sh) have this directory as well.
Yes, it's the standard pattern.
quoted
+/^[vA-Z0-9_]+$/ {
Small nit. Should this be length restricted at the least ? Like each CAP entries should not exceed a certain length.
If you want to send a patch by all means, I don't think it's useful though - it doesn't matter to the software and the main issue is taste which is going to get considered regardless of what software says, if people are happy with an identifer that hits some limit they're just going to raise the limit.
Small nit. Should it be print "#endif /* __ASM_CPUCAPS_H */" instead in order to be complete.
I guess. Given that this is merged that'd need to be an incremental patch. Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling through the irrelevant quoted material.