Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe()
From: Baruch Siach <baruch@tkos.co.il>
Date: 2021-05-11 13:50:48
Also in:
dri-devel, linux-mediatek
Hi Zhen Lei, On Tue, May 11 2021, Zhen Lei wrote:
quoted hunk ↗ jump to hunk
When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot <redacted> Signed-off-by: Zhen Lei <redacted> --- drivers/gpu/drm/mediatek/mtk_cec.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c index e9cef5c0c8f7eff..fd593ff99bfd447 100644 --- a/drivers/gpu/drm/mediatek/mtk_cec.c +++ b/drivers/gpu/drm/mediatek/mtk_cec.c@@ -197,7 +197,6 @@ static int mtk_cec_probe(struct platform_device *pdev) cec->regs = devm_ioremap_resource(dev, res); if (IS_ERR(cec->regs)) { ret = PTR_ERR(cec->regs); - dev_err(dev, "Failed to ioremap cec: %d\n", ret); return ret;
You can just return PTR_ERR() directly. No need to set 'ret'. baruch
}
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel