Re: [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-05-27 15:04:37
Also in:
linux-devicetree, linux-gpio, linux-omap
Hi Rob, On Fri, May 21, 2021 at 8:24 PM Rob Herring [off-list ref] wrote:
On Fri, May 21, 2021 at 12:23:47PM +0200, Geert Uytterhoeven wrote:quoted
On Fri, May 21, 2021 at 12:04 PM Linus Walleij [off-list ref] wrote:quoted
On Fri, May 21, 2021 at 9:54 AM Geert Uytterhoeven [off-list ref] wrote:quoted
Convert the PCF857x-compatible I/O expanders Device Tree binding documentation to json-schema. Document missing compatible values, properties, and gpio hogs. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>(...)quoted
Perhaps the "ti,pcf8575" construct should be removed, and the few users fixed instead?You would rather list it as deprecated I think? It is ABI...All DTS files use the "nxp,pcf8575" fallback, except for arch/x86/platform/ce4100/falconfalls.dts. The latter ain't working with Linux, as the Linux driver doesn't match against "ti,pcf8575"...
Correction: i2c_device_id-based matching ignores the vendor part of the compatible value. One day this is gonna bite us...
Perhaps can it just be removed?
I think so. All other users of similar I2C GPIO expanders just use the compatible values of the original NXP parts.
quoted
quoted
quoted
+patternProperties: + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": + type: objectBut this is already in /dtschema/schemas/gpio/gpio-hog.yaml for nodename, isn't that where it properly belongs? I'm however confused here Rob will know what to do.This one is a bit odd.quoted
If we leave this out, something still has to refer to it? I see no other binding doing that...It's selected by 'gpio-hog' being present, but here you need to make sure that's the case.
OK. Fixed.
And I would hope you could define the node name to be just 1 of the 2 cases.
Yep, the latter is fine.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel