On Thu, May 27, 2021 at 08:37:58AM +0200, Etienne Carriere wrote:

Hello Sudeep,

On Wed, 26 May 2021 at 20:28, Sudeep Holla [off-list ref] wrote:

quoted

Convert the old text format binding for System Control and Management Interface
(SCMI) Message Protocol into the new and shiny YAML format.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Cristian Marussi <cristian.marussi@arm.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Jim Quinlan <jim2101024@gmail.com>
Cc: Etienne Carriere <redacted>
Cc: Peter Hilber <redacted>
Signed-off-by: Sudeep Holla <redacted>
---
 .../devicetree/bindings/arm/arm,scmi.txt      | 224 ---------------
 .../bindings/firmware/arm,scmi.yaml           | 270 ++++++++++++++++++
 2 files changed, 270 insertions(+), 224 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/arm,scmi.txt
 create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi.yaml

Hi,

I have converted all the bindings except the below regulator part of the
binding. This needs to be addressed before merging ofcourse. Just posting
the remaining changes to get feedback and also ask suggestion for the below:

        scmi_voltage: protocol@17 {
          reg = <0x17>;
          regulators {
            regulator_devX: regulator@0 {
              reg = <0x0>;
              regulator-max-microvolt = <3300000>;
            };

            regulator_devY: regulator@9 {
              reg = <0x9>;
              regulator-min-microvolt = <500000>;
              regulator-max-microvolt = <4200000>;
            };
          };
        };

I will reply with things I have tried separately to avoid confusion with this
the patch here.

Few minor typos, but LGTM for this part, aside a comment on SCMI
version reference.

Both old and new descriptions refer to SCMI v1.0 (DEN0056A) in both
description text and URL reference.
Not mentioning the version would age better. From the implementation,
versions are already well managed at discovery and enumeration so we
don't expect regressions due to spec version.

At:
  -  the SCMI as described in ARM document number ARM DEN 0056A ("ARM
System Control
  +  the SCMI as described in ARM document number ARM DEN 0056 ("ARM
System Control
and at:
  -  [0] http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/index.html
  +  [0] https://developer.arm.com/documentation/den0056/latest

Good point, most of the recent specs, I am referring to latest. This predates
that practice. I will update this and fix typos pointed out. Thanks for taking
a look at this.

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel