Re: [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select
From: Rob Herring <robh@kernel.org>
Date: 2021-05-18 13:21:25
Also in:
dri-devel, linux-devicetree
On Sat, May 15, 2021 at 10:43:15PM +0200, Marek Vasut wrote:
quoted hunk ↗ jump to hunk
The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to select input pixel data sampling edge. Add DT property "pclk-sample", not the same as the one used by display timings but rather the same as used by media, to define the pixel data sampling edge. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Alexandre Torgue <redacted> Cc: Andrzej Hajda <redacted> Cc: Antonio Borneo <redacted> Cc: Benjamin Gaignard <redacted> Cc: Biju Das <biju.das.jz@bp.renesas.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Philippe Cornu <redacted> Cc: Rob Herring <robh+dt@kernel.org> Cc: Sam Ravnborg <redacted> Cc: Vincent Abriou <redacted> Cc: Yannick Fertre <redacted> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com To: dri-devel@lists.freedesktop.org --- V4: New patch split from combined V3 --- .../bindings/display/bridge/lvds-codec.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml index 304a1367faaa..f4dd16bd69d2 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml@@ -64,6 +64,14 @@ properties: - port@0 - port@1 + pclk-sample: + description: + Data sampling on rising or falling edge. + enum: + - 0 # Falling edge + - 1 # Rising edge + default: 0
This is already defined in video-interfaces.yaml, why are you redefining it here? It's also defined to be an endpoint property, so move it there and reference video-interfaces.yaml.
quoted hunk ↗ jump to hunk
+ powerdown-gpios: description: The GPIO used to control the power down line of this device.@@ -71,6 +79,16 @@ properties: power-supply: true +if: + not: + properties: + compatible: + contains: + const: lvds-encoder +then: + properties: + pclk-sample: false
This constraint would be difficult to express with the property in an endpoint. I'd just drop it. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel