RE: [PATCH 2/2] mmc: sdhci-esdhc-imx: add support for disabling HS400 mode via DT
From: Bough Chen <haibo.chen@nxp.com>
Date: 2021-05-10 06:29:34
Also in:
linux-devicetree, linux-mmc
-----Original Message----- From: Lucas Stach [mailto:dev@lynxeye.de] Sent: 2021年5月9日 4:57 To: Rob Herring <robh+dt@kernel.org>; Ulf Hansson
[off-list ref];
Adrian Hunter [off-list ref] Cc: Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam [off-list ref]; linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] mmc: sdhci-esdhc-imx: add support for disabling HS400 mode via DT On some boards the data strobe line isn't wired up, rendering HS400
support
broken, even if both the controller and the eMMC claim to support it.
Allow to
quoted hunk ↗ jump to hunk
disable HS400 mode via DT. Signed-off-by: Lucas Stach <dev@lynxeye.de> --- drivers/mmc/host/sdhci-esdhc-imx.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/mmc/host/sdhci-esdhc-imx.cb/drivers/mmc/host/sdhci-esdhc-imx.c index a20459744d21..1d6068507fb6 100644--- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c@@ -1483,6 +1483,9 @@ sdhci_esdhc_imx_probe_dt(struct platform_device*pdev, if (of_find_property(np, "no-1-8-v", NULL)) host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; + if (of_find_property(np, "no-mmc-hs400", NULL)) + host->quirks2 &= ~SDHCI_QUIRK2_CAPS_BIT63_FOR_HS400; +
Hi Lucas I suggest you move the change to mmc_of_parse() in drivers/mmc/core/host.c You also need to take care of the HS400ES mode. Regards Haibo Chen
if (of_property_read_u32(np, "fsl,delay-line",
&boarddata->delay_line))
boarddata->delay_line = 0; -- 2.31.1