Re: [PATCH] video: fbdev: imxfb: Fix an error message
flat view
From: Christophe JAILLET <hidden>
Date: 2021-05-07 07:11:26
Also in:
dri-devel, kernel-janitors, linux-fbdev, lkml
Le 07/05/2021 à 07:05, Uwe Kleine-König a écrit :
Hello Christophe, On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote:quoted
'ret' is known to be 0 here. No error code is available, so just remove it from the error message. Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of direct pointer deref") Signed-off-by: Christophe JAILLET <redacted> --- drivers/video/fbdev/imxfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index 7f8debd2da06..ad598257ab38 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c@@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev) info->screen_buffer = dma_alloc_wc(&pdev->dev, fbi->map_size, &fbi->map_dma, GFP_KERNEL); if (!info->screen_buffer) { - dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret); + dev_err(&pdev->dev, "Failed to allocate video RAM\n"); ret = -ENOMEM; goto failed_map; }Reviewed-by: Uwe Kleine-König <redacted> Are you using this driver, or did you find that problem using some static checker?
No, I'm not using this driver AFAIK. It has been spotted by coccinelle with a hand-made script which tries to find places where error code is used before being initialized. The script in it-self is not really interesting. It is easy to write and my own version trigger way to much false positives. CJ
Best regards Uwe
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel