Hi Anand,

On Mon, May 3, 2021 at 5:29 PM Anand Moon [off-list ref] wrote:
[...]

quoted

quoted

+static struct meson_ee_pwrc_mem_domain meson_pwrc_mem_hdmi[] = {
+       { HHI_MEM_PD_REG0, GENMASK(15, 8) },
+};
+

the VPU power domain already includes:
  VPU_HHI_MEMPD(HHI_MEM_PD_REG0),
whereas VPU_HHI_MEMPD is bits[15:8]

Having two power domains which are managing the same registers sounds
like it'll be causing some trouble
So for now this is (as I am not even sure what the goal here is):
NACKed-by: Martin Blumenstingl [off-list ref]

Ok, thanks. On the line of Ethernet PD, I tried to add this accordingly.

From what I understand the VPU power domain is special because the
display pipeline consists of multiple components (HDMI, VPU, ...)
that's why the handling currently is special

whenever I try something new it fails. Please ignore this series.

if the VPU and HDMI power domains were separate (from hardware
perspective, not from driver perspective) then your change is a good
step forward.
in that case VPU_HHI_MEMPD would need to be removed from wherever it's
currently used -> that means we need to also decide if we want to
break compatibility with older (before this series) .dtbs


Best regards,
Martin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel