Thread (3 messages) 3 messages, 2 authors, 2021-05-26

RE: [PATCH v2] ARM: dts: dra7: Fix duplicate USB4 device node

From: Tammana, Gowtham <hidden>
Date: 2021-05-26 19:48:35
Also in: linux-devicetree, linux-omap, lkml

-----Original Message-----
From: Anna, Suman
Sent: Wednesday, May 26, 2021 1:01 PM

Hi Gowtham,

On 5/26/21 12:20 PM, Gowtham Tammana wrote:
quoted
With [1] USB4 device node got defined in dra74x.dtsi file. However,
there was a prior defintion of the same in [2] which didn't get removed
I like this approach and is more in line with the original move of USB4
node
into dra74x.dtsi file.

Looks like you mixed up [1] and [2] or I misunderstand your terminology.
Yes, 1 and 2 got mixed up here. Will post a v3.
Also,
let's be precise, it is the USB4 target-module node that got duplicated in
[2],
USB4 node always existed but outside of ti-sysc control before [2] and did
not
conflict with the target-module node added in [1].
quoted
causing boot failures.
on what boards? Is it affecting all of them?
I have a dra7-evm board and see failure on it. This should also affect
Dra76-evm, am572x beagle boards, am574x as they all pull in dra74x.dtsi.
Will mention these in the v3 update.

Thanks,
Gowtham 
USB4 node is present only in DRA74x variants so
quoted
keeping the entry in dra74x.dtsi and removing it from the top level
interconnect hierarchy dra7-l4.dtsi file.

Since USB4 is only included in DRA74x variants, remove its reference
for AM5718, DRA71x and DR72x boards.

[1]: commit 549fce068a311 ("ARM: dts: dra7: Add l4 interconnect
hierarchy and ti-sysc data")
[2]: commit c7b72abca61ec ("ARM: OMAP2+: Drop legacy platform data for
dra7 dwc3")

Fixes: c7b72abca61ec ("ARM: OMAP2+: Drop legacy platform data for dra7
dwc3")
quoted
Signed-off-by: Gowtham Tammana <redacted>
---
v2:
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help