Thread (9 messages) flat view 9 messages, 5 authors, 2021-06-18

RE: [PATCH v13 1/2] media: dt-bindings: imx-jpeg: Add compatible for i.MX8QM JPEG codec

From: Aisheng Dong <aisheng.dong@nxp.com>
Date: 2021-05-24 03:19:27
Also in: linux-devicetree, linux-media, lkml

quoted hunk ↗ jump to hunk
From: Mirela Rabulea (OSS) <redacted>
Sent: Sunday, May 23, 2021 5:11 AM

Add two more compatibles: "nxp,imx8qm-jpgdec" and " nxp,imx8qm-jpgenc".
Also update the compatible property to ensure mutually exclusive usage of
encoder and decoder compatibles.
Update examples.

Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
---
 .../bindings/media/nxp,imx8-jpeg.yaml           | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 5d13cbb5251b..5cc7b6a94c44 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -16,12 +16,15 @@ description: |-

 properties:
   compatible:
-    items:
-      - enum:
-            # JPEG decoder
-          - nxp,imx8qxp-jpgdec
-            # JPEG encoder
-          - nxp,imx8qxp-jpgenc
+    oneOf:
+      - items:
+          anyOf:
+            - const: nxp,imx8qxp-jpgdec
+            - const: nxp,imx8qm-jpgdec
+      - items:
+          anyOf:
I might wish to avoid using anyOF for jpeg cases and defined in a more
Straightforward way.

e.g.
properties:
  compatible:
    oneOf:
      - items:
        - enum:
              # JPEG decoder
          - nxp,imx8qxp-jpgdec
            # JPEG encoder
          - nxp,imx8qxp-jpgenc
      - items:
          - enum:
              - nxp,imx8qm-jpgdec
          - const: nxp,imx8qxp-jpgdec
      - items:
          - enum:
              - nxp,imx8qm-jpgenc
          - const: nxp,imx8qxp-jpgenc
Could you check if it works?

Regards
Aisheng
quoted hunk ↗ jump to hunk
+            - const: nxp,imx8qxp-jpgenc
+            - const: nxp,imx8qm-jpgenc

   reg:
     maxItems: 1
@@ -69,7 +72,7 @@ examples:
     };

     jpegenc: jpegenc@58450000 {
-        compatible = "nxp,imx8qxp-jpgenc";
+        compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
         reg = <0x58450000 0x00050000 >;
         interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help