Thread (37 messages) 37 messages, 3 authors, 2021-06-08

Re: [PATCH v3 10/16] ipmi: kcs_bmc: Don't enforce single-open policy in the kernel

From: Andrew Jeffery <hidden>
Date: 2021-05-24 00:40:02
Also in: linux-aspeed, linux-devicetree, lkml, openbmc


On Sat, 22 May 2021, at 03:00, Corey Minyard wrote:
On Mon, May 10, 2021 at 03:12:07PM +0930, Andrew Jeffery wrote:
quoted
Soon it will be possible for one KCS device to have multiple associated
chardevs exposed to userspace (for IPMI and raw-style access). However,
don't prevent userspace from:

1. Opening more than one chardev at a time, or
2. Opening the same chardev more than once.

System behaviour is undefined for both classes of multiple access, so
userspace must manage itself accordingly.
I don't understand why you want to allow this.  If the second open won't
work right, then why allow it?  Why remove code that causes the second
open to error?
Really I was just shifting the problem to userspace so it wasn't 
something I needed to address in the kernel. It seems I'm alone in 
thinking this is a good idea, as yourself, Zev, William and Joel 
(privately) have pushed back against it. Initially the idea was tied up 
in how I was doing some interrupt handling, but in revising the code 
that problem has gone away.

I'll just drop this patch and save everyone the heartburn of arguing 
about it :)

Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help