[PATCH] staging: vchiq_arm: Using copy_from_user() to copy data from userspace address
From: Nguyen Dinh Phi <hidden>
Date: 2021-05-22 06:09:44
Also in:
linux-staging, lkml
Subsystem:
staging subsystem, the rest · Maintainers:
Greg Kroah-Hartman, Linus Torvalds
This commit to fix the following sparse warning: incorrect type in assignment (different address spaces) expected void *[assigned] userdata got void [noderef] __user *userdata Signed-off-by: Nguyen Dinh Phi <redacted> --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index afbf01b7364c..2a4fc599f977 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c@@ -960,7 +960,10 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance, current->pid); userdata = &waiter->bulk_waiter; } else { - userdata = args->userdata; + if (copy_from_user(userdata, args->userdata, sizeof(args->userdata))) { + ret = -EFAULT; + goto out; + } } status = vchiq_bulk_transfer(args->handle, NULL, args->data, args->size,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel