Re: [PATCH v5 2/4] dt-bindings: iommu: rockchip: Add compatible for v2
From: Robin Murphy <robin.murphy@arm.com>
Date: 2021-05-21 11:52:18
Also in:
linux-devicetree, linux-iommu, linux-rockchip, lkml
On 2021-05-21 09:36, Benjamin Gaignard wrote:
quoted hunk ↗ jump to hunk
Add compatible for the second version of IOMMU hardware block. RK356x IOMMU can also be link to a power domain. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> Reviewed-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/iommu/rockchip,iommu.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml index 099fc2578b54..d2e28a9e3545 100644 --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml@@ -19,7 +19,9 @@ description: |+ properties: compatible: - const: rockchip,iommu + enum: + - rockchip,iommu + - rockchip,rk3568-iommu reg: items:@@ -48,6 +50,9 @@ properties: "#iommu-cells": const: 0 + power-domains: + maxItems: 1 +
Nit: power domains are already present on various IOMMU nodes since RK3288 - it feels like strictly this should be in patch #1 to fix the existing binding as part of the conversion, but on the other hand I can't really imagine anyone caring *that* much about dtscheck bisecting cleanly :) Robin.
rockchip,disable-mmu-reset:
$ref: /schemas/types.yaml#/definitions/flag
description: |_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel