Re: [PATCH 0/6] Don't use BIT() macro in UAPI headers

From
Borislav Petkov <bp@alien8.de>
Date
2021-05-20 12:18:48
Also in
kvm, linux-media, lkml
Reply to
Joe Richey, 2021-05-20
On Thu, May 20, 2021 at 03:43:37AM -0700, Joe Richey wrote:
This patch series changes all UAPI uses of BIT() to just be open-coded.
However, there really should be a check for this in checkpatch.pl
Wanna add that check too?
Currently, the script actually _encourages_ users to use the BIT macro
even if adding things to UAPI.
How so?

This is with your first patch:

$ ./scripts/checkpatch.pl /tmp/bit.01
total: 0 errors, 0 warnings, 7 lines checked

/tmp/bit.01 has no obvious style problems and is ready for submission.

Also, in your commit messages you refer to patches with patchwork links
- please use the respective upstream commit IDs instead. Grep for
"Fixes:" here:

Documentation/process/submitting-patches.rst

for more info.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (31 messages) 31 messages, 9 authors, last reply 2021-05-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help