Thread (13 messages) 13 messages, 3 authors, 2021-05-03

Re: [PATCH 0/7] Input: mtk-pmic-keys - add support for MT6358

From: Mattijs Korpershoek <hidden>
Date: 2021-04-29 14:59:46
Also in: linux-mediatek

Hi Matthias, Dmitry, Lee,

Mattijs Korpershoek [off-list ref] writes:

Please ignore this series for now
The MediaTek MT6358 PMIC has support for two buttons: PWR and HOME.

The interrupt logic is a little different than other PMICs from the
same family:
* for MT6323 and MT6397, we have one interrupt source per button
* for MT6358, we have two interrupts lines per button: the press and
* release interrupts are distinct sources.

These series:
* Fix a NULL ptr error when we use mtk-pmic-keys without dts code
I've submitted this as a separate bugfix [1] to ease the review.

[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20210429143811.2030717-1-mkorpershoek@baylibre.com/
* Rework the mt6397 driver to prepare for this different interrupt logic
* Add support for the MT6358 power buttons

This has been functionally tested (using evtest) on
the mt8183-pumpkin board on linux/master

It has also been used for a couple of months in a downstream
tree based on v5.4.

Mattijs Korpershoek (7):
  Input: mtk-pmic-keys - check for NULL on of_match_device()
  mfd: mt6397: add mt6358 register definitions for power key
  mfd: mt6397: keys: use named IRQs instead of index
  dt-bindings: input: mtk-pmic-keys: add MT6358 binding definition
  Input: mtk-pmic-keys - add support for MT6358
I'll send a v2 for these
  mfd: mt6397: Add PMIC keys for MT6358
  arm64: dts: mt6358: add mt6358-keys node

 .../bindings/input/mtk-pmic-keys.txt          |  5 +-
 arch/arm64/boot/dts/mediatek/mt6358.dtsi      | 12 ++++
 drivers/input/keyboard/mtk-pmic-keys.c        | 59 +++++++++++++++++--
 drivers/mfd/mt6397-core.c                     | 20 +++++--
 include/linux/mfd/mt6358/registers.h          |  2 +
 5 files changed, 89 insertions(+), 9 deletions(-)


base-commit: 4a0225c3d208cfa6e4550f2210ffd9114a952a81
-- 
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help