Re: [PATCH][next] PCI: mediatek-gen3: Add missing null pointer check
From: Lorenzo Pieralisi <hidden>
Date: 2021-04-30 08:40:35
Also in:
kernel-janitors, linux-mediatek, linux-pci, lkml
On Thu, Apr 29, 2021 at 12:00:40PM +0100, Colin King wrote:
From: Colin Ian King <redacted>
The call to platform_get_resource_byname can potentially return null, so
add a null pointer check to avoid a null pointer dereference issue.
Addresses-Coverity: ("Dereference null return")
Fixes: 441903d9e8f0 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
Signed-off-by: Colin Ian King <redacted>
---
drivers/pci/controller/pcie-mediatek-gen3.c | 2 ++
1 file changed, 2 insertions(+)Squashed into the commit it is fixing, in my pci/mediatek branch. Thanks, Lorenzo
quoted hunk ↗ jump to hunk
diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c index 20165e4a75b2..3c5b97716d40 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c@@ -721,6 +721,8 @@ static int mtk_pcie_parse_port(struct mtk_pcie_port *port) int ret; regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pcie-mac"); + if (!regs) + return -EINVAL; port->base = devm_ioremap_resource(dev, regs); if (IS_ERR(port->base)) { dev_err(dev, "failed to map register base\n");-- 2.30.2
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel