RE: [PATCH 1/2] thermal: imx_sc: add missing of_node_put for loop iteration
From: Jacky Bai <ping.bai@nxp.com>
Date: 2021-04-27 08:55:42
Also in:
linux-pm, lkml
Subject: [PATCH 1/2] thermal: imx_sc: add missing of_node_put for loop
iteration
Early exits from for_each_available_child_of_node() should decrement the
node reference counter. Reported by Coccinelle:
drivers/thermal/imx_sc_thermal.c:93:1-33: WARNING:
Function "for_each_available_child_of_node" should have of_node_put()
before return around line 97.Reviewed-by: Jacky Bai <ping.bai@nxp.com> BR Jacky Bai
quoted hunk ↗ jump to hunk
Signed-off-by: Krzysztof Kozlowski <redacted> --- drivers/thermal/imx_sc_thermal.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/thermal/imx_sc_thermal.cb/drivers/thermal/imx_sc_thermal.c index b01d28eca7ee..8d76dbfde6a9 100644--- a/drivers/thermal/imx_sc_thermal.c +++ b/drivers/thermal/imx_sc_thermal.c@@ -93,6 +93,7 @@ static int imx_sc_thermal_probe(struct platform_device*pdev) for_each_available_child_of_node(np, child) { sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL); if (!sensor) { + of_node_put(child); of_node_put(sensor_np); return -ENOMEM; }@@ -104,6 +105,7 @@ static int imx_sc_thermal_probe(structplatform_device *pdev) dev_err(&pdev->dev, "failed to get valid sensor resource id: %d\n", ret); + of_node_put(child); break; }@@ -114,6 +116,7 @@ static int imx_sc_thermal_probe(structplatform_device *pdev) if (IS_ERR(sensor->tzd)) { dev_err(&pdev->dev, "failed to register thermal zone\n"); ret = PTR_ERR(sensor->tzd); + of_node_put(child); break; } -- 2.25.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel