RE: [PATCH V5 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP

Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support
i.MX7ULP/8MN/8MP

On Fri, Apr 23, 2021 at 11:28:00PM +0000, Peng Fan wrote:

quoted

quoted

Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support
i.MX7ULP/8MN/8MP

On Thu, 22 Apr 2021 at 19:01, Peng Fan [off-list ref] wrote:

quoted

Hi Mathieu,

quoted

Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support
i.MX7ULP/8MN/8MP

On Wed, Apr 21, 2021 at 10:20:14AM +0800, peng.fan@oss.nxp.com

wrote:

quoted

quoted

quoted

From: Peng Fan <peng.fan@nxp.com>

V5:
 Add R-b tag
 Move the change in detect mode of patch 5 to patch 7 Per
Mathieu's comments

V4:
 Typo fix
 patch 4: take state as a check condition  patch 5: move
regmap lookup/attach to imx_rproc_detect_mode  patch 6: add
imx_rproc_clk_enable for optional clk  patch 8: use
switch/case in imx_rproc_detect_mode
V3:
 Add A-b tag for Patch 1/2
 Fix the checkpatch warning for Patch 6,8

V2:
 Patch 1/8, use fsl as vendor, typo fix  Because patchset [1]
has
v2 version, patch 5,6,7,8 are adapted that  change.

This patchset is to support i.MX7ULP/8MN/8MP, also includes a
patch to parse fsl,auto-boot

One of the request I had from the last revision was to
explicitly list what other patchset this work depends on and
what branch it is based of, something I can't find here.

Sorry, that patchset has been merged, so I remove that line.
I should mention that that patchset has been merged into Linux-next

tree.

quoted

quoted

quoted

And what branch this set should be applied to is missing.

I take latest linux-next/master for my upstream new feature work.

quoted

quoted

quoted

As such I am dropping this set and won't look at another
revision before May 22nd.

Ah. Is it just because that the dependency patchset not been
mentioned or you have issue applying the patchset that delay the
patchset for one

month?

quoted

Both.

I replay my flow:
git fetch linux-next
git checkout linux-next/master -b master-next-4-24-2021 pwclient list
-w "Peng Fan (OSS)" -s New | grep V5 | awk '{print $1}' | xargs -I {}
pwclient git-am {}

It could successfully apply the patchset.
Applying patch #12215291 using 'git am'
Description: [V5,1/8] dt-bindings: remoteproc: imx_rproc: add
fsl,auto-boot property
Applying: dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot
property Applying patch #12215293 using 'git am'
Description: [V5,2/8] dt-bindings: remoteproc: imx_rproc: add i.MX7ULP
support
Applying: dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support
Applying patch #12215295 using 'git am'
Description: [V5,3/8] dt-bindings: remoteproc: imx_rproc: support
i.MX8MN/P
Applying: dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P
Applying patch #12215297 using 'git am'
Description: [V5,4/8] remoteproc: imx_rproc: parse fsl,auto-boot
Applying: remoteproc: imx_rproc: parse fsl,auto-boot Applying patch
#12215299 using 'git am'
Description: [V5,5/8] remoteproc: imx_rproc: initial support for
mutilple start/stop method
Applying: remoteproc: imx_rproc: initial support for mutilple
start/stop method Applying patch #12215301 using 'git am'
Description: [V5,6/8] remoteproc: imx_rproc: make clk optional
Applying: remoteproc: imx_rproc: make clk optional Applying patch
#12215303 using 'git am'
Description: [V5,7/8] remoteproc: imx_rproc: support i.MX7ULP
Applying: remoteproc: imx_rproc: support i.MX7ULP Applying patch
#12215305 using 'git am'
Description: [V5,8/8] remoteproc: imx_rproc: support i.MX8MN/P
Applying: remoteproc: imx_rproc: support i.MX8MN/P


If anything wrong my work flow conflicts with Linux remoteproc
subsystem upstream flow, please correct me, and I'll follow.

Thanks for your time and patience on reviewing my patches. Sorry for
the inconvince that I bring in.

Anyway please share me your flow to apply patches, I will try to avoid
unhappy things in following patches.

All I asked is that you list the branch your work is based on _and_ any
dependencies, something you did not do.

ok, got it.

I review hundreds of patchsets every year and knowing exactly how to work
with a series goes a long way in saving precious time, time that can be used to
review other people's submissions.

I am not angry at you but at the same time I can't review your patches if you
are not ready to help me do so.

Understand. Since one month is a bit long period, I'll post v6 later to avoid
potential conflicts. Or if you could help check this V5 patchset based on
Linux-next/master, that would be appreciated.

Thanks,
Peng.

quoted

Thanks,
Peng.

quoted

quoted

Thanks,
Peng.

quoted

quoted

Peng Fan (8):
  dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot property
  dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support
  dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P
  remoteproc: imx_rproc: parse fsl,auto-boot
  remoteproc: imx_rproc: initial support for mutilple start/stop

method

quoted

quoted

quoted

quoted

quoted

  remoteproc: imx_rproc: make clk optional
  remoteproc: imx_rproc: support i.MX7ULP
  remoteproc: imx_rproc: support i.MX8MN/P

 .../bindings/remoteproc/fsl,imx-rproc.yaml    |  11 +-
 drivers/remoteproc/imx_rproc.c                | 196

+++++++++++++++---

quoted

 2 files changed, 173 insertions(+), 34 deletions(-)

--
2.30.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel