Re: [PATCH v6 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S
From: Pavel Machek <hidden>
Date: 2021-04-26 11:03:28
Also in:
linux-devicetree, linux-rockchip, lkml
From: Pavel Machek <hidden>
Date: 2021-04-26 11:03:28
Also in:
linux-devicetree, linux-rockchip, lkml
Hi!
quoted
quoted
quoted
- Fixed format of LED nodes Changes in v5: - Dropped the empty PCIe node - Dropped useless `/delete-property/` - Renamed LED nodes [...]Applied, thanks! [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48 [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992Sorry for late review, but: + label = "red:sys"; This should be red:power based on the discussion in earlier threads.However based on the introduction from FriendlyELEC[1], this is not the "power" lamp... "LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)"
It is always on, and "sys" is not a valid function. I'd suggest labeling it as "red:power". Feel free to make other suggestion but lets keep existing functions. Pavel -- http://www.livejournal.com/~pavelmachek