Re: [PATCH] dt-bindings: net: mediatek/ralink: remove unused bindings
From: Rob Herring <robh@kernel.org>
Date: 2021-04-23 18:42:12
Also in:
linux-devicetree, linux-mediatek, lkml, netdev
On Wed, Apr 21, 2021 at 5:05 PM Ilya Lipnitskiy [off-list ref] wrote:
Hi Rob, On Wed, Apr 21, 2021 at 3:03 PM Rob Herring [off-list ref] wrote:quoted
On Mon, Apr 19, 2021 at 07:42:22PM -0700, Ilya Lipnitskiy wrote:quoted
Revert commit 663148e48a66 ("Documentation: DT: net: add docs for ralink/mediatek SoC ethernet binding") No in-tree drivers use the compatible strings present in these bindings, and some have been superseded by DSA-capable mtk_eth_soc driver, so remove these obsolete bindings.Looks like maybe OpenWRT folks are using these. If so, you can't revert them.Indeed, there are out of tree drivers for some of these. I wasn't sure what the dt-binding policy was for such use cases - can you point me to a definitive reference?
Perhaps we should write that down more explicitly, but I think it is pretty rare actually. And really, I'd like to require we have at least 1 dts user. Though, then we'd just have dead dts files. More generally, other projects use the bindings and dts files. The bindings and dts files live in the kernel tree for convenience and the simple fact that is where the vast majority of both developers and hardware support are. There are exceptions of course such as h/w that doesn't run Linux. I'm all for removing this if no one cares (please try to find out) or if the existing binding is just bad (doesn't match the h/w or is incomplete in an incompatible way). I would have expected in the 5 years since it was added, a user (either dts file or driver) would have appeared. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel