Thread (9 messages) 9 messages, 3 authors, 2021-04-19

Re: [PATCH v5] arm64: Enable perf events based hard lockup detector

From: Will Deacon <will@kernel.org>
Date: 2021-04-19 17:03:43
Also in: lkml

On Mon, Apr 12, 2021 at 05:31:13PM +0530, Sumit Garg wrote:
On Tue, 30 Mar 2021 at 18:00, Sumit Garg [off-list ref] wrote:
quoted
On Tue, 30 Mar 2021 at 14:07, Lecopzer Chen [off-list ref] wrote:
quoted
quoted
quoted
On Fri, 15 Jan 2021 at 17:32, Sumit Garg [off-list ref] wrote:
quoted
With the recent feature added to enable perf events to use pseudo NMIs
as interrupts on platforms which support GICv3 or later, its now been
possible to enable hard lockup detector (or NMI watchdog) on arm64
platforms. So enable corresponding support.

One thing to note here is that normally lockup detector is initialized
just after the early initcalls but PMU on arm64 comes up much later as
device_initcall(). So we need to re-initialize lockup detection once
PMU has been initialized.

Signed-off-by: Sumit Garg <redacted>
---

Changes in v5:
- Fix lockup_detector_init() invocation to be rather invoked from CPU
  binded context as it makes heavy use of per-cpu variables and shouldn't
  be invoked from preemptible context.
Do you have any further comments on this?
Since there aren't any further comments, can you re-pick this feature for 5.13?
I'd still like Mark's Ack on this, as the approach you have taken doesn't
really sit with what he was suggesting.

I also don't understand how all the CPUs get initialised with your patch,
since the PMU driver will be initialised after SMP is up and running.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help