Thread (3 messages) 3 messages, 3 authors, 2021-04-10

Re: [PATCH] pinctrl: samsung: use 'int' for register masks in Exynos

From: Linus Walleij <hidden>
Date: 2021-04-10 00:07:53
Also in: linux-gpio, linux-samsung-soc, lkml

On Thu, Apr 8, 2021 at 9:50 PM Krzysztof Kozlowski
[off-list ref] wrote:
The Special Function Registers on all Exynos SoC, including ARM64, are
32-bit wide, so entire driver uses matching functions like readl() or
writel().  On 64-bit ARM using unsigned long for register masks:
1. makes little sense as immediately after bitwise operation it will be
   cast to 32-bit value when calling writel(),
2. is actually error-prone because it might promote other operands to
   64-bit.

Addresses-Coverity: Unintentional integer overflow
Signed-off-by: Krzysztof Kozlowski <redacted>
(...)
Please apply it directly, I don't have any patches for Samsung pinctrl
in my tree.
OK! Patch applied!

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help