Thread (5 messages) 5 messages, 3 authors, 2021-04-16

Re: [PATCH] clk: uniphier: Fix potential infinite loop

From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2021-04-09 06:47:45
Also in: kernel-janitors, linux-clk, lkml

On Thu, Apr 8, 2021 at 12:25 AM Colin King [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Colin Ian King <redacted>

The for-loop iterates with a u8 loop counter i and compares this
with the loop upper limit of num_parents that is an int type.
There is a potential infinite loop if num_parents is larger than
the u8 loop counter. Fix this by making the loop counter the same
type as num_parents.

Addresses-Coverity: ("Infinite loop")
Fixes: 734d82f4a678 ("clk: uniphier: add core support code for UniPhier clock driver")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/clk/uniphier/clk-uniphier-mux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/uniphier/clk-uniphier-mux.c b/drivers/clk/uniphier/clk-uniphier-mux.c
index 462c84321b2d..ce219e0d2a85 100644
--- a/drivers/clk/uniphier/clk-uniphier-mux.c
+++ b/drivers/clk/uniphier/clk-uniphier-mux.c
@@ -34,7 +34,7 @@ static u8 uniphier_clk_mux_get_parent(struct clk_hw *hw)
        int num_parents = clk_hw_get_num_parents(hw);
        int ret;
        unsigned int val;
-       u8 i;
+       int i;

        ret = regmap_read(mux->regmap, mux->reg, &val);
        if (ret)
--
2.30.2
clk_hw_get_num_parents() returns 'unsigned int', so
I think 'num_parents' should also have been 'unsigned int'.

Maybe, the loop counter 'i' also should be 'unsigned int' then?


-- 
Best Regards
Masahiro Yamada

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help