Thread (3 messages) 3 messages, 2 authors, 2021-04-01

Re: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock

From: chenlifu <hidden>
Date: 2021-04-01 03:39:39
Also in: kernel-janitors, lkml

Kindly pinging ...

Best Regards,
Chen Lifu

在 2021/3/27 17:52, Chen Lifu 写道:
quoted hunk ↗ jump to hunk
From: Lifu Chen <redacted>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <redacted>
Signed-off-by: Lifu Chen <redacted>
---
  arch/arm/mach-sa1100/simpad.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
index c7fb9a73e4c5..c183432880d3 100644
--- a/arch/arm/mach-sa1100/simpad.c
+++ b/arch/arm/mach-sa1100/simpad.c
@@ -45,7 +45,7 @@
   */
  
  static long cs3_shadow;
-static spinlock_t cs3_lock;
+static DEFINE_SPINLOCK(cs3_lock);
  static struct gpio_chip cs3_gpio;
  
  long simpad_get_cs3_ro(void)
@@ -379,8 +379,6 @@ static int __init simpad_init(void)
  {
  	int ret;
  
-	spin_lock_init(&cs3_lock);
-
  	cs3_gpio.label = "simpad_cs3";
  	cs3_gpio.base = SIMPAD_CS3_GPIO_BASE;
  	cs3_gpio.ngpio = 24;
.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help