Thread (3 messages) read the whole thread 3 messages, 3 authors, 2021-03-30

Re: [PATCH] mmc: sdhci-esdhc-imx: separate 100/200 MHz pinctrl states check

From: Ulf Hansson <hidden>
Date: 2021-03-30 10:51:41
Also in: linux-mmc

On Fri, 26 Mar 2021 at 12:02, Shawn Guo [off-list ref] wrote:
From: Shawn Guo <redacted>

As indicated by function esdhc_change_pinstate(), SDR50 and DDR50
require pins_100mhz, while SDR104 and HS400 require pins_200mhz.  Some
system design may support SDR50 and DDR50 with 100mhz pin state only
(without 200mhz one).  Currently the combined 100/200 MHz pinctrl state
check prevents such system from running SDR50 and DDR50.  Separate the
check to support such system design.

Signed-off-by: Shawn Guo <redacted>
Applied for next, thanks!

Kind regards
Uffe

quoted hunk ↗ jump to hunk
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index a20459744d21..aa45901325b9 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -434,10 +434,10 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
                         * Do not advertise faster UHS modes if there are no
                         * pinctrl states for 100MHz/200MHz.
                         */
-                       if (IS_ERR_OR_NULL(imx_data->pins_100mhz) ||
-                           IS_ERR_OR_NULL(imx_data->pins_200mhz))
-                               val &= ~(SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_DDR50
-                                        | SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_HS400);
+                       if (IS_ERR_OR_NULL(imx_data->pins_100mhz))
+                               val &= ~(SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_DDR50);
+                       if (IS_ERR_OR_NULL(imx_data->pins_200mhz))
+                               val &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_HS400);
                }
        }

--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help