RE: [PATCH RFC] soc: fujitsu: Add cache driver code
From: tan.shaopeng@fujitsu.com <hidden>
Date: 2021-03-05 07:50:33
On Thu, Mar 4, 2021 at 11:46 AM Will Deacon [off-list ref] wrote:quoted
On Thu, Mar 04, 2021 at 10:34:43AM +0000, tan.shaopeng@fujitsu.comwrote:quoted
quoted
quoted
On Wed, Mar 3, 2021 at 10:38 AM tan.shaopeng [off-list ref] wrote:quoted
+ +config FUJITSU_CACHE + tristate "FUJITSU Cache Driver" + depends on ARM64_VHE || COMPILE_TEST + help + FUJITSU Cache Driver + + This driver offers cache functions for A64FX system. + Loading this cache driver, control registers will be set toenablequoted
quoted
quoted
quoted
+ these functions, and advanced settings registers will be setbyquoted
quoted
quoted
defaultquoted
+ values. After loading this driver, you can use the defaultvalues ofquoted
quoted
quoted
thequoted
+ advanced settings registers or set the advanced settingsregistersquoted
quoted
quoted
quoted
+ from EL0. Unloading this driver, control registers will beclear toquoted
quoted
quoted
quoted
+ disable these functions. + When built as a module, this will be called as"fujitsu_cache".quoted
quoted
quoted
My feeling is that this code should be in arch/arm64/, as the cache is generally considered part of the CPU, rather than part of the wider SoC design, or something that can be controlled separately from the core kernel and memory management code.Thanks for your advice. I also would like to hear the opinions from other soc&arm maintainers, and then consider whether to add this to arch/arm64/.Given that all of this is outside of the scope of the architecture, I don't think that arch/arm64/ is the right place for it. Perhaps this would fit into the resctrl rework that James has been doing for MPAM?Indeed, that sounds like a good starting point. I don't understand enough about either of the two to be sure, but it sounds like there is some overlap in functionality, and ideally we would have one user interface that can deal with all the hardware implementations (intel, arm, fujitsu and any future ones).
I don't know resctrl well and I’m not sure if it can be used for sector cache now. Also, it seems to me that resctrl has no control with hardware prefetch. I will learn more about resctrl. Best regards, Tan Shaopeng _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel