Re: [PATCH v2 1/3] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr
From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2021-03-31 11:02:47
Also in:
linux-mediatek, lkml
On 01/02/2021 13:14, Bilal Wasim wrote:
When "bus_prot_reg_update" is true, the driver should use INFRA_TOPAXI_PROTECTEN for both setting and clearing the bus protection. However, the driver does not use this mask for clearing bus protection which causes failure when booting the imgtec gpu. Corrected and tested with mt8173 chromebook. Signed-off-by: Bilal Wasim <redacted> Reviewed-by: Hsin-Yi Wang <redacted>
BUS_PROT_UPDATE_TOPAXI is also used in mt8167. I'd need feedback if this would break that SoC before accepting this patch. Regards, Matthias
quoted hunk ↗ jump to hunk
--- drivers/soc/mediatek/mtk-pm-domains.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h index 141dc76054e6..7454c0b4f768 100644 --- a/drivers/soc/mediatek/mtk-pm-domains.h +++ b/drivers/soc/mediatek/mtk-pm-domains.h@@ -60,7 +60,7 @@ #define BUS_PROT_UPDATE_TOPAXI(_mask) \ BUS_PROT_UPDATE(_mask, \ INFRA_TOPAXI_PROTECTEN, \ - INFRA_TOPAXI_PROTECTEN_CLR, \ + INFRA_TOPAXI_PROTECTEN, \ INFRA_TOPAXI_PROTECTSTA1) struct scpsys_bus_prot_data {
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel