Re: [PATCH net-next v1 2/3] net: phy: at803x: AR8085: add loopback support
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-03-30 14:50:36
Also in:
lkml, netdev
On Tue, Mar 30, 2021 at 03:54:06PM +0200, Oleksij Rempel wrote:
quoted hunk ↗ jump to hunk
PHY loopback is needed for the ethernet controller self test support. This PHY was tested with the FEC sefltest. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/phy/at803x.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index d7799beb811c..8679738cf2ab 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c@@ -326,6 +326,30 @@ static int at803x_resume(struct phy_device *phydev) return phy_modify(phydev, MII_BMCR, BMCR_PDOWN | BMCR_ISOLATE, 0); } +static int at803x_loopback(struct phy_device *phydev, bool enable) +{ + int ret; + + if (enable) + ret = phy_clear_bits(phydev, MII_BMCR, BMCR_ANENABLE); + else + ret = phy_set_bits(phydev, MII_BMCR, BMCR_ANENABLE);
Auto-neg might of been turned off when entering self test. So you
should leave it off when existing self test.
Or maybe call phy_config_aneg() which should reconfigure the PHY back
how it was.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel