Thread (4 messages) 4 messages, 3 authors, 2021-03-31

Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

From: Hsin-Yi Wang <hidden>
Date: 2021-03-30 10:49:31
Also in: dri-devel, linux-mediatek, lkml

On Tue, Mar 30, 2021 at 5:43 PM Enric Balletbo i Serra
[off-list ref] wrote:
Hi,

On 3/2/21 12:07, Enric Balletbo i Serra wrote:
quoted
From: Boris Brezillon <boris.brezillon@collabora.com>

This patch adds the missing MODULE_DEVICE_TABLE definitions on different
Mediatek drivers which generates correct modalias for automatic loading
when these drivers are compiled as an external module.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Enric Balletbo i Serra <redacted>
Reviewed-by: Hsin-Yi Wang <redacted>
A gentle ping for someone to review this patchset :-)

Thanks,
  Enric
quoted
---

 drivers/gpu/drm/mediatek/mtk_cec.c      | 2 ++
 drivers/gpu/drm/mediatek/mtk_dpi.c      | 1 +
 drivers/gpu/drm/mediatek/mtk_drm_drv.c  | 1 +
 drivers/gpu/drm/mediatek/mtk_dsi.c      | 1 +
 drivers/gpu/drm/mediatek/mtk_hdmi.c     | 1 +
 drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 +
 6 files changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c
index cb29b649fcdb..3b86e626e459 100644
--- a/drivers/gpu/drm/mediatek/mtk_cec.c
+++ b/drivers/gpu/drm/mediatek/mtk_cec.c
@@ -7,6 +7,7 @@
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
@@ -247,6 +248,7 @@ static const struct of_device_id mtk_cec_of_ids[] = {
      { .compatible = "mediatek,mt8173-cec", },
      {}
 };
+MODULE_DEVICE_TABLE(of, mtk_cec_of_ids);

 struct platform_driver mtk_cec_driver = {
      .probe = mtk_cec_probe,
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 52f11a63a330..2680370652fd 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -822,6 +822,7 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
      },
      { },
 };
+MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);

 struct platform_driver mtk_dpi_driver = {
      .probe = mtk_dpi_probe,
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f49a809689b..e4645c8ae1c0 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -470,6 +470,7 @@ static const struct of_device_id mtk_drm_of_ids[] = {
        .data = &mt8183_mmsys_driver_data},
      { }
 };
+MODULE_DEVICE_TABLE(of, mtk_drm_of_ids);

 static int mtk_drm_probe(struct platform_device *pdev)
 {
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 0527480c07be..c71ce62d1bec 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1193,6 +1193,7 @@ static const struct of_device_id mtk_dsi_of_match[] = {
        .data = &mt8183_dsi_driver_data },
      { },
 };
+MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);

 struct platform_driver mtk_dsi_driver = {
      .probe = mtk_dsi_probe,
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 8ee55f9e2954..b4696a9d73f7 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -1818,6 +1818,7 @@ static const struct of_device_id mtk_drm_hdmi_of_ids[] = {
      },
      {}
 };
+MODULE_DEVICE_TABLE(of, mtk_drm_hdmi_of_ids);

 static struct platform_driver mtk_hdmi_driver = {
      .probe = mtk_drm_hdmi_probe,
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
index 62dbad5675bb..6207eac88550 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
@@ -335,6 +335,7 @@ static const struct of_device_id mtk_hdmi_ddc_match[] = {
      { .compatible = "mediatek,mt8173-hdmi-ddc", },
      {},
 };
+MODULE_DEVICE_TABLE(of, mtk_hdmi_ddc_match);

 struct platform_driver mtk_hdmi_ddc_driver = {
      .probe = mtk_hdmi_ddc_probe,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help