Re: [PATCH] [v3] drm/imx: imx-ldb: fix out of bounds array access warning
From: Philipp Zabel <hidden>
Date: 2021-03-25 07:09:41
Also in:
dri-devel, lkml
On Thu, Mar 25, 2021 at 10:03:23AM +0800, Liu Ying wrote:
On Wed, 2021-03-24 at 17:47 +0100, Arnd Bergmann wrote:quoted
From: Arnd Bergmann <arnd@arndb.de> When CONFIG_OF is disabled, building with 'make W=1' produces warnings about out of bounds array access: drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct clk *[4]' [-Werror=array-bounds] Add an error check before the index is used, which helps with the warning, as well as any possible other error condition that may be triggered at runtime. The warning could be fixed by adding a Kconfig depedency on CONFIG_OF, but Liu Ying points out that the driver may hit the out-of-bounds problem at runtime anyway. Signed-off-by: Arnd Bergmann <arnd@arndb.de>Reviewed-by: Liu Ying <victor.liu@nxp.com>
Thank you, applied to imx-drm/fixes. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel