Re: [RESEND 1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header
From: Linus Walleij <hidden>
Date: 2021-03-24 11:51:15
Also in:
lkml
On Wed, Mar 3, 2021 at 4:50 PM Lee Jones [off-list ref] wrote:
On Wed, 03 Mar 2021, Alexandre Belloni wrote:quoted
On 03/03/2021 12:41:49+0000, Lee Jones wrote:quoted
Both the caller and the supplier's source file should have access to the include file containing the prototypes. Fixes the following W=1 kernel build warning(s): drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | void at91_pinctrl_gpio_suspend(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | void at91_pinctrl_gpio_resume(void) | ^~~~~~~~~~~~~~~~~~~~~~~~ Cc: Russell King <linux@armlinux.org.uk> Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Ludovic Desroches <ludovic.desroches@microchip.com> Signed-off-by: Lee Jones <redacted>I'm pretty sure you had my ack on v3 ;) Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> or again, alternatively, I can apply it with Linus' ackThat would be my preference, thanks.
Acked-by: Linus Walleij <redacted> Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel