Thread (10 messages) 10 messages, 3 authors, 2021-05-19

Re: [PATCH V2 RESEND 2/4] PM / devfreq: Remove the invalid description for get_target_freq

From: Chanwoo Choi <hidden>
Date: 2021-03-23 14:57:09
Also in: linux-pm, lkml

On 21. 3. 23. 오후 4:20, Dong Aisheng wrote:
quoted hunk ↗ jump to hunk
First of all, no_central_polling was removed since
commit 7e6fdd4bad03 ("PM / devfreq: Core updates to support devices
which can idle")
Secondly, get_target_freq() is not only called only with update_devfreq()
notified by OPP now, but also min/max freq qos notifier.

So remove this invalid description now to avoid confusing.

Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
  Documentation/ABI/testing/sysfs-class-devfreq | 5 +----
  drivers/devfreq/governor.h                    | 2 --
  2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-class-devfreq b/Documentation/ABI/testing/sysfs-class-devfreq
index 386bc230a33d..5e6b74f30406 100644
--- a/Documentation/ABI/testing/sysfs-class-devfreq
+++ b/Documentation/ABI/testing/sysfs-class-devfreq
@@ -97,10 +97,7 @@ Description:
  		object. The values are represented in ms. If the value is
  		less than 1 jiffy, it is considered to be 0, which means
  		no polling. This value is meaningless if the governor is
-		not polling; thus. If the governor is not using
-		devfreq-provided central polling
-		(/sys/class/devfreq/.../central_polling is 0), this value
-		may be useless.
+		not polling.
  
  		A list of governors that support the node:
  		- simple_ondmenad
diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
index 244634465170..2d69a0ce6291 100644
--- a/drivers/devfreq/governor.h
+++ b/drivers/devfreq/governor.h
@@ -57,8 +57,6 @@
   *			Basically, get_target_freq will run
   *			devfreq_dev_profile.get_dev_status() to get the
   *			status of the device (load = busy_time / total_time).
- *			If no_central_polling is set, this callback is called
- *			only with update_devfreq() notified by OPP.
   * @event_handler:      Callback for devfreq core framework to notify events
   *                      to governors. Events include per device governor
   *                      init and exit, opp changes out of devfreq, suspend
Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help