Re: [PATCHv3 2/6] arm64: don't use GENERIC_IRQ_MULTI_HANDLER

From
Christoph Hellwig <hch@infradead.org>
Date
2021-03-15 19:29:29
Also in
lkml
Reply to
Mark Rutland, 2021-03-15
On Mon, Mar 15, 2021 at 11:56:25AM +0000, Mark Rutland wrote:
From: Marc Zyngier <maz@kernel.org>

In subsequent patches we want to allow irqchip drivers to register as
FIQ handlers, with a set_handle_fiq() function. To keep the IRQ/FIQ
paths similar, we want arm64 to provide both set_handle_irq() and
set_handle_fiq(), rather than using GENERIC_IRQ_MULTI_HANDLER for the
former.
Having looked through the series I do not understand this rationale
at all.  You've only added the default_handle_irq logic, which seems
perfectly suitable and desirable for the generic version.  Please
don't fork off generic code for no good reason.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (14 messages) 14 messages, 4 authors, last reply 2021-03-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help