Re: [net-next PATCH v7 08/16] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

On Thu, Mar 11, 2021 at 8:00 PM Calvin Johnson
[off-list ref] wrote:

On Thu, Mar 11, 2021 at 02:09:37PM +0200, Andy Shevchenko wrote:

quoted

On Thu, Mar 11, 2021 at 8:21 AM Calvin Johnson
[off-list ref] wrote:

...

quoted

quoted

+config FWNODE_MDIO
+       def_tristate PHYLIB

(Seems "selectable only" item)

What do you mean by "selectable only" item here? Can you please point to some
other example?

The Kconfig sections without descriptions are not user-visible.
No user can run menuconfig and check a box with "I want this to be compiled".

tristate // selectable-only
tristate "bla bla bla" // user visible and selectable

quoted

quoted

+       depends on ACPI
+       depends on OF

Wouldn't be better to have
  depends on (ACPI || OF) || COMPILE_TEST

And honestly I don't understand it in either (AND or OR) variant. Why
do you need a dependency like this for fwnode API?

Here, fwnode_mdiobus_register_phy() uses objects from both ACPI and OF.

APIs? Calls? What really fails if we have !ACPI and / or !OF?

quoted

Moreover dependencies don't work for "selectable only" items.

quoted

+       depends on PHYLIB
+       select FIXED_PHY

--
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel