Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager

On Wed, Mar 10, 2021 at 10:12 AM Rob Herring [off-list ref] wrote:

On Wed, Mar 10, 2021 at 3:50 AM Nava kishore Manne [off-list ref] wrote:

quoted

Hi Rob,

        Thanks for providing the review comments.
Please find my response inline.

quoted

-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Tuesday, March 9, 2021 1:50 AM
To: Nava kishore Manne <redacted>
Cc: mdf@kernel.org; trix@redhat.com; Michal Simek <redacted>;
gregkh@linuxfoundation.org; Jolly Shah [off-list ref]; Rajan Vaja
[off-list ref]; arnd@arndb.de; Manish Narani
[off-list ref]; Amit Sunil Dhamne [off-list ref]; Tejas
Patel [off-list ref]; linux-fpga@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; chinnikishore369@gmail.com; Appana Durga
Kedareswara Rao [off-list ref]
Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga
manager

On Thu, Mar 04, 2021 at 12:32:23PM +0530, Nava kishore Manne wrote:

quoted

From: Appana Durga Kedareswara rao <redacted>

This patch adds binding doc for versal fpga manager driver.

Why do you need a DT entry for this? Can't the Versal firmware driver
instantiate the fpga-mgr device?

This dt entry is need to handle the fpga regions properly for both full and Partial bitstream loading use cases and it cannot be done by Versal firmware driver instantiate.

Ah yes, I forgot about that.

Looking at this some more, please convert xlnx,zynqmp-firmware.txt to
schema and add the node for this there. We don't need a whole other
schema file just for a node and compatible. Also, looks like
xlnx,zynqmp-pcap-fpga.txt is the prior version of the same thing, so
it should be handled in the schema too.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel