Thread (11 messages) flat view 11 messages, 3 authors, 2021-03-20

Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: 2021-03-04 20:57:59
Also in: linux-omap, lkml


On 04/03/2021 09:21, Tony Lindgren wrote:
We have of_translate_address() already do of_node_put() as needed.
I probably looked at __of_translate_address() earlier by accident
that of_translate_address() uses.
I do not see of_node_put() in of_translate_address() and
  __of_translate_address() is doing of_node_get(dev);
?
quoted hunk ↗ jump to hunk
Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
  drivers/clocksource/timer-ti-dm-systimer.c | 2 --
  1 file changed, 2 deletions(-)
diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
--- a/drivers/clocksource/timer-ti-dm-systimer.c
+++ b/drivers/clocksource/timer-ti-dm-systimer.c
@@ -265,7 +265,6 @@ static void __init dmtimer_systimer_assign_alwon(void)
  				    pa == 0x48318000)
  					continue;
  
-				of_node_put(np);
  				break;
  			}
  		}
@@ -300,7 +299,6 @@ static u32 __init dmtimer_systimer_find_first_available(void)
  				continue;
  			}
  
-			of_node_put(np);
  			break;
  		}
  	}
-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help