Hi Andy

El 4 mar 2021, a las 11:43, Andy Shevchenko [off-list ref] escribió:

On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas
[off-list ref] wrote:

quoted

Add a helper for registering BCM63XX pin controllers.

Signed-off-by: Álvaro Fernández Rojas <redacted>
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

This SoB is in a strange place.

Why?
Can’t we both sign the patches?

The order is wrong taking into account the From header (committer). So,
it's not clear who is the author, who is a co-developer, and who is
the committer (one person may utilize few roles).
Check for the rest of the series as well (basically this is the rule
of thumb to recheck entire code for the comment you have got at any
single place of it).

Jonas was the original author of this patches (sent back in 2016) and I’m just continuing his work and trying to get those patches upstreamed.
I don’t know how to do it correctly, so a little hint would be appreciated.

...

quoted

+static const struct of_device_id bcm63xx_gpio_of_match[] = {
+       { .compatible = "brcm,bcm6318-gpio", },
+       { .compatible = "brcm,bcm6328-gpio", },
+       { .compatible = "brcm,bcm6358-gpio", },
+       { .compatible = "brcm,bcm6362-gpio", },
+       { .compatible = "brcm,bcm6368-gpio", },
+       { .compatible = "brcm,bcm63268-gpio", },

quoted

+       { /* sentinel */ },

Comma is not needed in terminator line

Ok, I will remove it.

quoted

+};

...

quoted

+       dev_info(dev, "registered\n");

Unneeded noise.

Ok, I will remove it.

...

quoted

+#include <linux/pinctrl/pinctrl.h>
+#include <linux/regmap.h>

The rule of thumb is to include only the headers that the below code
is direct user of.

Ok, so I will move them to pinctrl-bcm63xx.c.
I added them because they were needed for pinctrl_desc.

The above are not used anyhow, while missed types.h and several
forward declarations.

… so I should include linux/types.h and I don’t know what you mean by “several forward declarations”…

quoted

+#include "../core.h"

Seems the same.

Ok, I will move it to pinctrl-bcm63xx.c.

quoted

+#define BCM63XX_BANK_GPIOS 32
+
+struct bcm63xx_pinctrl_soc {
+       struct pinctrl_ops *pctl_ops;
+       struct pinmux_ops *pmx_ops;
+
+       const struct pinctrl_pin_desc *pins;
+       unsigned npins;
+
+       unsigned int ngpios;
+};
+
+struct bcm63xx_pinctrl {
+       struct device *dev;
+       struct regmap *regs;
+
+       struct pinctrl_desc pctl_desc;
+       struct pinctrl_dev *pctl_dev;
+
+       void *driver_data;
+};

--
With Best Regards,
Andy Shevchenko

Best regards,
Álvaro.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel