Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name
From: John Garry <hidden>
Date: 2021-03-04 09:38:22
Also in:
lkml
On 04/03/2021 03:26, Shunsuke Nakamura wrote:
From: Shunsuke Nakamura <redacted> Add the lexical definition of event name so that the numbers are recognizable.
Sorry for the hassle, but it's not clear that we got a definitive conclusion on this patch from v6 series: https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/ (local) Would it be so much worse for you to change format of these event names to not start with a numberic? Thanks
quoted hunk ↗ jump to hunk
A64FX defines an event name that starts with a number. - 0inst_commit - 1inst_commit - 2inst_commit - 3inst_commit - 4inst_commit Signed-off-by: Shunsuke Nakamura <redacted> Acked-by: John Garry <redacted> --- tools/perf/util/parse-events.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l index 0b36285a9435..33f627187415 100644 --- a/tools/perf/util/parse-events.l +++ b/tools/perf/util/parse-events.l@@ -205,7 +205,7 @@ bpf_source [^,{}]+\.c[a-zA-Z0-9._]* num_dec [0-9]+ num_hex 0x[a-fA-F0-9]+ num_raw_hex [a-fA-F0-9]+ -name [a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]* +name [a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]* name_tag [\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\'] name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?.:]* drv_cfg_term [a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)?
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel