Re: [PATCH 15/18] irqchip/apple-aic: Add support for the Apple Interrupt Controller

From
Arnd Bergmann <arnd@kernel.org>
Date
2021-02-08 10:30:52
Reply to
Marc Zyngier, 2021-02-08
On Mon, Feb 8, 2021 at 10:25 AM Marc Zyngier [off-list ref] wrote:
On Thu, 04 Feb 2021 20:39:48 +0000, Hector Martin [off-list ref] wrote:
quoted
+{
+     return readl(ic->base + reg);
Please consider using the _relaxed accessors, as I don't think any of
these interacts with memory (apart from IPIs, of course).
MSI interrupts require serializing with DMA, so at the minimum I think there
needs to be something that ensures that DMA from device into memory
has completed before delivering the completion interrupt to a driver. This
may already be implied when the AIC is entered, but this is hard to know
without actual hardware specs.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (111 messages) 111 messages, 9 authors, last reply 2021-02-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help