[arm:for-next 9/26] arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for 'fdt_check_mem_start'

2 messages, 2 authors, 2021-02-03 · open the first message on its own page

[arm:for-next 9/26] arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for 'fdt_check_mem_start'

From: kernel test robot <hidden>
Date: 2021-02-02 22:33:07

tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git for-next
head:   d6bae7564ab1254b46ee3a3953ce1eb682a09602
commit: 0673cb38951215060d7993b43ad3c45cd413c2c3 [9/26] ARM: 9045/1: uncompress: Validate start of physical memory against passed DTB
config: arm-randconfig-r035-20210202 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add arm git://git.armlinux.org.uk/~rmk/linux-arm.git
        git fetch --no-tags arm for-next
        git checkout 0673cb38951215060d7993b43ad3c45cd413c2c3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):
quoted
arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for 'fdt_check_mem_start' [-Wmissing-prototypes]
      62 | uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)
         |          ^~~~~~~~~~~~~~~~~~~


vim +/fdt_check_mem_start +62 arch/arm/boot/compressed/fdt_check_mem_start.c

    46	
    47	/*
    48	 * Check the start of physical memory
    49	 *
    50	 * Traditionally, the start address of physical memory is obtained by masking
    51	 * the program counter.  However, this does require that this address is a
    52	 * multiple of 128 MiB, precluding booting Linux on platforms where this
    53	 * requirement is not fulfilled.
    54	 * Hence validate the calculated address against the memory information in the
    55	 * DTB, and, if out-of-range, replace it by the real start address.
    56	 * To preserve backwards compatibility (systems reserving a block of memory
    57	 * at the start of physical memory, kdump, ...), the traditional method is
    58	 * always used if it yields a valid address.
    59	 *
    60	 * Return value: start address of physical memory to use
    61	 */
  > 62	uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Re: [arm:for-next 9/26] arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for 'fdt_check_mem_start'

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-02-03 07:59:08

On Tue, Feb 2, 2021 at 11:31 PM kernel test robot [off-list ref] wrote:
tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git for-next
head:   d6bae7564ab1254b46ee3a3953ce1eb682a09602
commit: 0673cb38951215060d7993b43ad3c45cd413c2c3 [9/26] ARM: 9045/1: uncompress: Validate start of physical memory against passed DTB
config: arm-randconfig-r035-20210202 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add arm git://git.armlinux.org.uk/~rmk/linux-arm.git
        git fetch --no-tags arm for-next
        git checkout 0673cb38951215060d7993b43ad3c45cd413c2c3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):
quoted
quoted
arch/arm/boot/compressed/fdt_check_mem_start.c:62:10: warning: no previous prototype for 'fdt_check_mem_start' [-Wmissing-prototypes]
      62 | uint32_t fdt_check_mem_start(uint32_t mem_start, const void *fdt)
         |          ^~~~~~~~~~~~~~~~~~~
Most global C functions in arch/arm/boot/compressed/ do not have previous
prototypes, as they are called from assembler only.  The only exception is
arch/arm/boot/compressed/misc.h.

Russell: do you want to have prototypes for all of them?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help