Re: [PATCH] media: exynos4-is: add missing call to of_node_put()
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2021-02-25 14:43:18
Also in:
linux-media, linux-samsung-soc, lkml
On Thu, 25 Feb 2021 at 10:04, Yang Li [off-list ref] wrote:
In one of the error paths of the for_each_child_of_node() loop in fimc_md_parse_one_endpoint, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 492. Reported-by: Abaci Robot <redacted>
Please make the reports public. Otherwise the actual credits should go to Coccinelle not to some hidden/unknown tool...
quoted hunk ↗ jump to hunk
Signed-off-by: Yang Li <redacted> --- drivers/media/platform/exynos4-is/media-dev.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index 8e1e892..467bc69 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c@@ -489,6 +489,7 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd, for_each_child_of_node(port, ep) { ret = fimc_md_parse_one_endpoint(fmd, ep); if (ret < 0) + of_node_put(ep);
This is wrong... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel