Re: [PATCH 2/2] mmc: uniphier-sd: Fix a resource leak in the remove function
From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2021-02-22 11:49:00
Also in:
kernel-janitors, linux-mmc, lkml
On Sat, Feb 20, 2021 at 11:31 PM Christophe JAILLET [off-list ref] wrote:
A 'tmio_mmc_host_free()' call is missing in the remove function, in order
to balance a 'tmio_mmc_host_alloc()' call in the probe.
This is done in the error handling path of the probe, but not in the remove
function.
Add the missing call.
Fixes: 3fd784f745dd ("mmc: uniphier-sd: add UniPhier SD/eMMC controller driver")
Signed-off-by: Christophe JAILLET <redacted>Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
quoted hunk ↗ jump to hunk
--- drivers/mmc/host/uniphier-sd.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 6f0f05466917..ccbf9885a52b 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c@@ -660,6 +660,7 @@ static int uniphier_sd_remove(struct platform_device *pdev) tmio_mmc_host_remove(host); uniphier_sd_clk_disable(host); + tmio_mmc_host_free(host); return 0; } --2.27.0
-- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel