On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote:

quoted

Separate patch for trivial renaming.

I think it makes sense to do this rename together with the first change
above, as it keeps both functions symmetric. Otherwise we end up with an
inconsistent function naming between both patches. If you really want it
separate though, I can do that.

OK, keep your version.

quoted

quoted

Signed-off-by: Hector Martin <redacted>
---
  drivers/tty/serial/samsung_tty.c | 41 +++++++++++++++++++-------------
  1 file changed, 24 insertions(+), 17 deletions(-)

diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 21955be680a4..821cd0e4f870 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c

@@ -151,6 +151,9 @@ struct s3c24xx_uart_port {
  #endif
  };
+static void s3c24xx_serial_start_next_tx(struct s3c24xx_uart_port *ourport);
+static void s3c24xx_serial_tx_chars(struct s3c24xx_uart_port *ourport);
+
  /* conversion functions */
  #define s3c24xx_dev_to_port(__dev) dev_get_drvdata(__dev)

@@ -316,8 +319,6 @@ static void s3c24xx_serial_stop_tx(struct uart_port *port)
  	ourport->tx_mode = 0;
  }
-static void s3c24xx_serial_start_next_tx(struct s3c24xx_uart_port *ourport);
-

Why moving this? Why adding s3c24xx_serial_tx_chars() forward
declaration?

This should've gone in the next patch. A previous reviewer told me to put
declarations at the top of the file, so I put it there and moved this one
along with it, but I'll keep it to the additon only for v3.

Maybe I missed something in the context but it looked like
forward declaration s3c24xx_serial_tx_chars() was not needed? In such
case no need to move it.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel