Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-02-20 12:53:11
Also in:
lkml, netdev
On 20.02.2021 10:02, Serge Semin wrote:
On Thu, Feb 11, 2021 at 10:39:41AM +0000, Russell King - ARM Linux admin wrote:quoted
On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote:quoted
On Tue, Feb 09, 2021 at 10:56:46AM +0000, Russell King - ARM Linux admin wrote:quoted
On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote:quoted
Right, adding something like a genphy_{read,write}_mmd() doesn't make too much sense for now. What I meant is just exporting mmd_phy_indirect(). Then you don't have to open-code the first three steps of a mmd read/write. And it requires no additional code in phylib.... but at the cost that the compiler can no longer inline that code, as I mentioned in my previous reply. (However, the cost of the accesses will be higher.) On the plus side, less I-cache footprint, and smaller kernel code.Just to note mmd_phy_indirect() isn't defined with inline specifier, but just as static and it's used twice in the drivers/net/phy/phy-core.c unit. So most likely the compiler won't inline the function code in there.You can't always tell whether the compiler will inline a static function or not.Andrew, Heiner, Russell, what is your final decision about this? Shall we export the mmd_phy_indirect() method, implement new genphy_{read,write}_mmd() or just leave the patch as is manually accessing the MMD register in the driver?
If in doubt, leaving the patch as is would be fine with me.
-Sergeyquoted
quoted
Anyway it's up to the PHY library maintainers to decide. Please settle the issue with Heiner and Andrew then. I am ok with both solutions and will do as you decide.FYI, *I* am one of the phylib maintainers. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel