Re: [PATCH] pinctrl: stm32: add missing of_node_put
From: foss <fabien.dessenne@foss.st.com>
Date: 2021-02-15 13:58:57
Also in:
linux-gpio, lkml
Possibly related (same subject, not in this thread)
- 2021-03-02 · Re: [PATCH] pinctrl: stm32: add missing of_node_put · Linus Walleij <hidden>
- 2021-02-15 · [PATCH] pinctrl: stm32: add missing of_node_put · angkery <hidden>
Resending in plain-text format. On 15/02/2021 2:26 pm, foss wrote:
Hi Junlin Thank you for the patch! Fabienquoted
From: Junlin Yang<redacted> Fix OF node leaks by calling of_node_put in for_each_available_child_of_node when the cycle returns. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Signed-off-by: Junlin Yang<redacted>Acked-by: Fabien Dessenne <fabien.dessenne@foss.st.com>quoted
--- drivers/pinctrl/stm32/pinctrl-stm32.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 7d9bded..da72e3e 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c@@ -1542,8 +1542,10 @@ int stm32_pctl_probe(struct platform_device *pdev) if (of_property_read_bool(child, "gpio-controller")) { bank->rstc = of_reset_control_get_exclusive(child, NULL); - if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) + if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) { + of_node_put(child); return -EPROBE_DEFER; + } bank->clk = of_clk_get_by_name(child, NULL); if (IS_ERR(bank->clk)) {@@ -1551,6 +1553,7 @@ int stm32_pctl_probe(struct platform_device *pdev) dev_err(dev, "failed to get clk (%ld)\n", PTR_ERR(bank->clk)); + of_node_put(child); return PTR_ERR(bank->clk); } i++; --1.9.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel