Thread (39 messages) 39 messages, 8 authors, 2021-03-10

Re: [PATCH 08/21] clk: clkdev: Ignore suggestion to use gnu_printf() as it's not appropriate here

From: Lee Jones <hidden>
Date: 2021-02-12 09:37:10
Also in: linux-kbuild, lkml

On Thu, 11 Feb 2021, Stephen Boyd wrote:
Quoting Lee Jones (2021-01-26 04:45:27)
quoted
Fixes the following W=1 kernel build warning(s):

 drivers/clk/clkdev.c: In function ‘vclkdev_alloc’:
 drivers/clk/clkdev.c:173:3: warning: function ‘vclkdev_alloc’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <redacted>
---
 drivers/clk/clkdev.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index 0f2e3fcf0f19f..5e5f25d568724 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -153,6 +153,11 @@ struct clk_lookup_alloc {
        char    con_id[MAX_CON_ID];
 };
 
+#pragma GCC diagnostic push
+#ifndef __clang__
+#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
+#endif
Can this be some macro banished to compiler.h?
This is probably a question for Arnd.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help