quoted

+/* Configure Rx FIFO Flow control thresholds */ void
+mvpp23_rx_fifo_fc_en(struct mvpp2 *priv, int port, bool en) {
+	int val;

	u32 ?

OK.

quoted

+
+	val = mvpp2_read(priv, MVPP2_RX_FC_REG(port));
+
+	if (en)
+		val |= MVPP2_RX_FC_EN;
+	else
+		val &= ~MVPP2_RX_FC_EN;
+
+	mvpp2_write(priv, MVPP2_RX_FC_REG(port), val);

	if (en)
		val = MVPP2_RX_FC_EN;
	else
		val = 0;

	mvpp2_modify(priv + MVPP2_RX_FC_REG(port),
MVPP2_RX_FC_EN, val);

?

OK, I would use mvpp2_modify Here.

Thanks,
Stefan.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel