Re: [PATCH][next] soc: xilinx: vcu: remove deadcode on null divider check
From: Stephen Boyd <sboyd@kernel.org>
Date: 2021-02-11 03:29:17
Also in:
kernel-janitors, linux-clk, lkml
Quoting Colin King (2021-02-10 10:49:38)
quoted hunk ↗ jump to hunk
From: Colin Ian King <redacted> The pointer 'divider' has previously been null checked followed by a return, hence the subsequent null check is redundant deadcode that can be removed. Clean up the code and remove it. Fixes: 9c789deea206 ("soc: xilinx: vcu: implement clock provider for output clocks") Signed-off-by: Colin Ian King <redacted> --- drivers/clk/xilinx/xlnx_vcu.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/clk/xilinx/xlnx_vcu.c b/drivers/clk/xilinx/xlnx_vcu.c index d66b1315114e..607936d7a413 100644 --- a/drivers/clk/xilinx/xlnx_vcu.c +++ b/drivers/clk/xilinx/xlnx_vcu.c@@ -512,9 +512,6 @@ static void xvcu_clk_hw_unregister_leaf(struct clk_hw *hw) mux = clk_hw_get_parent(divider); clk_hw_unregister_mux(mux); - if (!divider) - return; -
This code is pretty confusing. Waiting for m.tretter@pengutronix.de to reply
clk_hw_unregister_divider(divider); }
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel