Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree
From: Tony Lindgren <tony@atomide.com>
Date: 2021-02-10 10:32:37
Also in:
linux-devicetree, lkml
* Hector Martin 'marcan' [off-list ref] [210208 12:05]:
On 08/02/2021 20.04, Krzysztof Kozlowski wrote:
...
quoted
quoted
+ clk24: clk24 {Just "clock". Node names should be generic.Really? Almost every other device device tree uses unique clock node names.
Yeah please just use generic node name "clock". FYI, we're still hurting because of this for the TI clock node names years after because the drivers got a chance to rely on the clock node name.. Using "clock" means your clock driver code won't get a chance to wrongly use the node name and you avoid similar issues. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel